upgrade pihole helm chart v0.26 -> v0.27

manifests/pihole/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## [2.27.0](https://github.com/MoJo2600/pihole-kubernetes/compare/pihole-2.26.2...pihole-2.27.0) (2024-11-28)
+
+
+### Features
+
+* add command option to set up readiness probe. ([#323](https://github.com/MoJo2600/pihole-kubernetes/issues/323)) ([f5c6ad3](https://github.com/MoJo2600/pihole-kubernetes/commit/f5c6ad3661a2a87e5014aff6c617ea0367177b24))
+* add the label app.kubernetes.io/name to deployment and services ([#321](https://github.com/MoJo2600/pihole-kubernetes/issues/321)) ([61ab00d](https://github.com/MoJo2600/pihole-kubernetes/commit/61ab00d1f7fe0cfabfc426bf484cec46fff6ed11))
+* configurable pathType for the ingress resource ([#317](https://github.com/MoJo2600/pihole-kubernetes/issues/317)) ([d3c09bc](https://github.com/MoJo2600/pihole-kubernetes/commit/d3c09bc0a6addc487ceda44b516e0714c06c1875))
+
 ## [2.26.2](https://github.com/MoJo2600/pihole-kubernetes/compare/pihole-2.26.1...pihole-2.26.2) (2024-10-27)
 
 

manifests/pihole/Chart.yaml

@@ -12,4 +12,4 @@ sources:
 - https://pi-hole.net/
 - https://github.com/pi-hole
 - https://github.com/pi-hole/docker-pi-hole
-version: 2.26.2
+version: 2.27.0

manifests/pihole/README.md

@@ -2,7 +2,7 @@
 
 Installs pihole in kubernetes
 
-![Version: 2.26.2](https://img.shields.io/badge/Version-2.26.2-informational?style=flat-square) ![AppVersion: 2024.07.0](https://img.shields.io/badge/AppVersion-2024.07.0-informational?style=flat-square) <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->[![All Contributors](https://img.shields.io/badge/all_contributors-27-blue.svg?style=flat-square)](#contributors-)<!-- ALL-CONTRIBUTORS-BADGE:END -->
+![Version: 2.27.0](https://img.shields.io/badge/Version-2.27.0-informational?style=flat-square) ![AppVersion: 2024.07.0](https://img.shields.io/badge/AppVersion-2024.07.0-informational?style=flat-square) <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->[![All Contributors](https://img.shields.io/badge/all_contributors-27-blue.svg?style=flat-square)](#contributors-)<!-- ALL-CONTRIBUTORS-BADGE:END -->
 
 ## Source Code
 
@@ -215,7 +215,7 @@ The following table lists the configurable parameters of the pihole chart and th
 | image.pullPolicy | string | `"IfNotPresent"` | the pull policy |
 | image.repository | string | `"pihole/pihole"` | the repostory to pull the image from |
 | image.tag | string | `""` | the docker tag, if left empty it will get it from the chart's appVersion |
-| ingress | object | `{"annotations":{},"enabled":false,"hosts":["chart-example.local"],"path":"/","tls":[]}` | Configuration for the Ingress |
+| ingress | object | `{"annotations":{},"enabled":false,"hosts":["chart-example.local"],"path":"/","pathType":"ImplementationSpecific","tls":[]}` | Configuration for the Ingress |
 | ingress.annotations | object | `{}` | Annotations for the ingress |
 | ingress.enabled | bool | `false` | Generate a Ingress resource |
 | maxSurge | int | `1` | The maximum number of Pods that can be created over the desired number of `ReplicaSet` during updating. |
@@ -239,16 +239,15 @@ The following table lists the configurable parameters of the pihole chart and th
 | podDnsConfig.nameservers[1] | string | `"8.8.8.8"` |  |
 | podDnsConfig.policy | string | `"None"` |  |
 | privileged | string | `"false"` | should container run in privileged mode |
-| probes | object | `{"liveness":{"enabled":true,"failureThreshold":10,"initialDelaySeconds":60,"port":"http","scheme":"HTTP","timeoutSeconds":5,"type":"httpGet"},"readiness":{"enabled":true,"failureThreshold":3,"initialDelaySeconds":60,"port":"http","scheme":"HTTP","timeoutSeconds":5}}` | Probes configuration |
+| probes | object | `{"liveness":{"enabled":true,"failureThreshold":10,"initialDelaySeconds":60,"port":"http","scheme":"HTTP","timeoutSeconds":5,"type":"httpGet"},"readiness":{"enabled":true,"failureThreshold":10,"initialDelaySeconds":60,"port":"http","scheme":"HTTP","timeoutSeconds":5,"type":"httpGet"}}` | Probes configuration |
 | probes.liveness.failureThreshold | int | `10` | threshold until the probe is considered failing |
 | probes.liveness.initialDelaySeconds | int | `60` | wait time before trying the liveness probe |
 | probes.liveness.timeoutSeconds | int | `5` | timeout in seconds |
 | probes.liveness.type | string | `"httpGet"` | Generate a liveness probe 'type' defaults to httpGet, can be set to 'command' to use a command type liveness probe. |
-| probes.readiness.enabled | bool | `true` | Generate a readiness probe |
+| probes.readiness.failureThreshold | int | `10` | threshold until the probe is considered failing |
-| probes.readiness.failureThreshold | int | `3` | The failure threshold |
+| probes.readiness.initialDelaySeconds | int | `60` | wait time before trying the readiness probe |
-| probes.readiness.initialDelaySeconds | int | `60` | Initial delay to wait for readiness check |
+| probes.readiness.timeoutSeconds | int | `5` | timeout in seconds |
-| probes.readiness.port | string | `"http"` | The port |
+| probes.readiness.type | string | `"httpGet"` | Generate a readiness probe 'type' defaults to httpGet, can be set to 'command' to use a command type readiness probe. |
-| probes.readiness.timeoutSeconds | int | `5` | The timeout in seconds |
 | regex | object | `{}` | list of blacklisted regex expressions to import during initial start of the container |
 | replicaCount | int | `1` | The number of replicas |
 | resources | object | `{}` | lines, adjust them as necessary, and remove the curly braces after 'resources:'. |

manifests/pihole/templates/deployment.yaml

@@ -4,6 +4,7 @@ metadata:
   name: {{ template "pihole.fullname" . }}
   labels:
     app: {{ template "pihole.name" . }}
+    app.kubernetes.io/name: {{ template "pihole.name" . }}
     chart: {{ template "pihole.chart" . }}
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
@@ -34,6 +35,7 @@ spec:
 {{- end }}
       labels:
         app: {{ template "pihole.name" . }}
+        app.kubernetes.io/name: {{ template "pihole.name" . }}
         release: {{ .Release.Name }}
     spec:
       {{- if .Values.antiaff.enabled }}
@@ -224,10 +226,15 @@ spec:
           {{- end }}
           {{- if .Values.probes.readiness.enabled }}
           readinessProbe:
+            {{- if eq .Values.probes.readiness.type "command" }}
+            exec:
+              command: {{ .Values.probes.readiness.command | required "An array of command(s) is required if 'type' is set to 'command'." | toYaml | nindent 16 }}
+            {{- else }}
             httpGet:
               path: /admin/index.php
               port: {{ .Values.probes.readiness.port }}
               scheme: {{ .Values.probes.readiness.scheme }}
+            {{- end }}
             initialDelaySeconds: {{ .Values.probes.readiness.initialDelaySeconds }}
             failureThreshold: {{ .Values.probes.readiness.failureThreshold }}
             timeoutSeconds: {{ .Values.probes.readiness.timeoutSeconds }}

manifests/pihole/templates/ingress.yaml

@@ -1,6 +1,7 @@
 {{- if .Values.ingress.enabled -}}
 {{- $serviceName := printf "%s-%s" (include "pihole.fullname" .) "web" -}}
 {{- $ingressPath := .Values.ingress.path -}}
+{{- $pathType := .Values.ingress.pathType -}}
 apiVersion: networking.k8s.io/v1
 kind: Ingress
 metadata:
@@ -28,7 +29,7 @@ spec:
       http:
         paths:
           - path: {{ $ingressPath }}
-            pathType: ImplementationSpecific
+            pathType: {{ $pathType }}
             backend:
               service:
                 name: {{ $serviceName }}

manifests/pihole/templates/service-dhcp.yaml

@@ -5,6 +5,7 @@ metadata:
   name: {{ template "pihole.fullname" . }}-dhcp
   labels:
     app: {{ template "pihole.name" . }}
+    app.kubernetes.io/name: {{ template "pihole.name" . }}
     chart: {{ template "pihole.chart" . }}
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
@@ -48,6 +49,7 @@ metadata:
   name: {{ template "pihole.fullname" . }}-dhcp-ivp6
   labels:
     app: {{ template "pihole.name" . }}
+    app.kubernetes.io/name: {{ template "pihole.name" . }}
     chart: {{ template "pihole.chart" . }}
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}

manifests/pihole/templates/service-dns-tcp.yaml

@@ -5,6 +5,7 @@ metadata:
   name: {{ template "pihole.fullname" . }}-dns-tcp
   labels:
     app: {{ template "pihole.name" . }}
+    app.kubernetes.io/name: {{ template "pihole.name" . }}
     chart: {{ template "pihole.chart" . }}
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
@@ -54,6 +55,7 @@ metadata:
   name: {{ template "pihole.fullname" . }}-dns-tcp-ipv6
   labels:
     app: {{ template "pihole.name" . }}
+    app.kubernetes.io/name: {{ template "pihole.name" . }}
     chart: {{ template "pihole.chart" . }}
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}

manifests/pihole/templates/service-dns-udp.yaml

@@ -5,6 +5,7 @@ metadata:
   name: {{ template "pihole.fullname" . }}-dns-udp
   labels:
     app: {{ template "pihole.name" . }}
+    app.kubernetes.io/name: {{ template "pihole.name" . }}
     chart: {{ template "pihole.chart" . }}
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
@@ -48,6 +49,7 @@ metadata:
   name: {{ template "pihole.fullname" . }}-dns-udp-ipv6
   labels:
     app: {{ template "pihole.name" . }}
+    app.kubernetes.io/name: {{ template "pihole.name" . }}
     chart: {{ template "pihole.chart" . }}
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}

manifests/pihole/templates/service-dns.yaml

@@ -5,6 +5,7 @@ metadata:
   name: {{ template "pihole.fullname" . }}-dns
   labels:
     app: {{ template "pihole.name" . }}
+    app.kubernetes.io/name: {{ template "pihole.name" . }}
     chart: {{ template "pihole.chart" . }}
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
@@ -55,6 +56,7 @@ metadata:
   name: {{ template "pihole.fullname" . }}-dns-ipv6
   labels:
     app: {{ template "pihole.name" . }}
+    app.kubernetes.io/name: {{ template "pihole.name" . }}
     chart: {{ template "pihole.chart" . }}
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}

manifests/pihole/templates/service-web.yaml

@@ -5,6 +5,7 @@ metadata:
   name: {{ template "pihole.fullname" . }}-web
   labels:
     app: {{ template "pihole.name" . }}
+    app.kubernetes.io/name: {{ template "pihole.name" . }}
     chart: {{ template "pihole.chart" . }}
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
@@ -64,6 +65,7 @@ metadata:
   name: {{ template "pihole.fullname" . }}-web-ipv6
   labels:
     app: {{ template "pihole.name" . }}
+    app.kubernetes.io/name: {{ template "pihole.name" . }}
     chart: {{ template "pihole.chart" . }}
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}

manifests/pihole/values.yaml

@@ -255,6 +255,7 @@ topologySpreadConstraints: []
 affinity: {}
 
 # -- Administrator password when not using an existing secret (see below)
+# -- Change the admin password prior to installing
 adminPassword: "admin"
 
 # -- Use an existing secret for the admin password.
@@ -264,7 +265,7 @@ admin:
   # -- Specify an existing secret to use as admin password
   existingSecret: ""
   # -- Specify the key inside the secret to use
-  passwordKey: "password"
+  passwordKey: ""
   # -- Specify [annotations](docs/Values.md#admin.annotations) to be added to the secret
   annotations:
     # reflector.v1.k8s.emberstack.com/reflection-allowed: "true"