Commit Graph

298 Commits

Author SHA1 Message Date
Joshua Chin
0cb9d4e467 Merge ../wordfreq_builder
Former-commit-id: 668f0fa67f
2015-07-13 11:03:18 -04:00
Joshua Chin
b25205ef8e Merge pull request #16 from LuminosoInsight/more-tweaking
More tweaking

Former-commit-id: 2c573b5a0e
2015-07-10 14:36:18 -04:00
Andrew Lin
3c5caa138a Merge pull request #17 from LuminosoInsight/alternative-func-to-regex
created alternate implementation of func-to-regex

Former-commit-id: 6efdaa308c
2015-07-10 14:32:49 -04:00
Joshua Chin
0594eb65c2 added comment about parsing_range
Former-commit-id: 7706496080
2015-07-10 14:27:48 -04:00
Joshua Chin
275b761fe1 %c is a thing
Former-commit-id: 447fb7aacd
2015-07-10 14:23:06 -04:00
Joshua Chin
1578a1eb0d merge
Former-commit-id: 2612bc23ff
2015-07-10 14:12:42 -04:00
Joshua Chin
b3ae254f87 updated func_to_regex to remove end check
Former-commit-id: 87830d138b
2015-07-10 14:10:26 -04:00
Andrew Lin
b77cb1ac75 Improve variable names.
Former-commit-id: 95da6985d4
2015-07-10 14:02:33 -04:00
Joshua Chin
087bde269c merged
Former-commit-id: e68f5b67a2
2015-07-10 13:33:17 -04:00
Joshua Chin
648f15e997 created alternate implementation of func-to-regex
Former-commit-id: 7c189ef129
2015-07-10 11:03:57 -04:00
Andrew Lin
8e89671560 Clarify the algorithm for range calculation using an explicit variable.
Former-commit-id: 6755741e7d
2015-07-09 16:47:33 -04:00
Andrew Lin
2b7d1249f6 Whoops -- put back 'file' as a variable name. (The perils of trusting syntax highlighting...)
Former-commit-id: f591e74663
2015-07-09 16:18:56 -04:00
Andrew Lin
bb196ad851 Remove an unused temporary.
Former-commit-id: 47ee662e24
2015-07-09 15:50:44 -04:00
Andrew Lin
081fde93e3 Express the combining of word frequencies in an explicitly associative and commutative way.
Former-commit-id: 32b4033d63
2015-07-09 15:29:05 -04:00
Andrew Lin
1cd48c26c2 Switch to a faster 'drop everything' style cache for word_frequency().
Former-commit-id: 2821f23e79
2015-07-09 14:32:16 -04:00
Andrew Lin
d1ba78b07c Close a file a little earlier.
Former-commit-id: b4bae84aac
2015-07-09 14:03:24 -04:00
Andrew Lin
f938ffccf9 Spacing tweaks.
Former-commit-id: 677ed6eb87
2015-07-09 13:26:49 -04:00
Andrew Lin
8961729401 Document the version of Unicode used to build the regexes.
Former-commit-id: 9f8464c2d1
2015-07-08 18:48:33 -04:00
Andrew Lin
8b3c5348e3 Tweaks to the regex generator for brevity:
* Don't repeat the logic that generates the ranges
  * Include only unassigned characters between two accepted ranges; this causes the resulting
    regexes to be a bit more readable.
  * Rearrange the script itself to avoid long lambdas and group helper functions together
  * Precompute the list of all the character classes for speed and terseness


Former-commit-id: cc6920d7e4
2015-07-08 15:29:31 -04:00
Andrew Lin
30de0ff17f Merge pull request #6 from LuminosoInsight/code-review-leftovers
Code review leftovers
2015-07-07 19:39:44 -04:00
Rob Speer
41dba74da2 add docstrings and remove some brackets 2015-07-07 18:22:51 -04:00
Rob Speer
20299b30b2 fix duplication
Former-commit-id: d4d7b2f72e
2015-07-07 18:18:27 -04:00
Rob Speer
66d5d0002f mention Google Books Ngrams in the word_frequency docstring
Former-commit-id: d9a5b452fd
2015-07-07 18:07:39 -04:00
Andrew Lin
4be5198158 Merge pull request #15 from LuminosoInsight/wordfreq-review
General style fixes and improvements from the code review

Former-commit-id: 8686a47a30
2015-07-07 16:53:17 -04:00
Joshua Chin
b145e02ce4 removed unused imports
Former-commit-id: b9578ae21e
2015-07-07 16:21:22 -04:00
Joshua Chin
8eac6bf006 added documentation to load ranges
Former-commit-id: af362480d5
2015-07-07 16:00:37 -04:00
Joshua Chin
4d3123e2ee cleaned up gen regex
Former-commit-id: 27ea107e6f
2015-07-07 16:00:24 -04:00
Joshua Chin
993bc4da15 revert to using global mecab_tokenize variable
Former-commit-id: 189a5b9cd6
2015-07-07 15:47:37 -04:00
Joshua Chin
927aaae920 updated minimum
Former-commit-id: 59c03e2411
2015-07-07 15:46:33 -04:00
Joshua Chin
a5dc6eb5fc updated emoji parser
Former-commit-id: f04ca8fc9e
2015-07-07 15:43:34 -04:00
Joshua Chin
0589bed362 updated docstring
Former-commit-id: 9b851f3afe
2015-07-07 15:33:51 -04:00
Joshua Chin
5772f1702d factored out range loading
Former-commit-id: 32803b235b
2015-07-07 15:33:36 -04:00
Joshua Chin
950e41c8bb fixed spacing
Former-commit-id: ae4699029d
2015-07-07 15:23:15 -04:00
Joshua Chin
aeea503739 fixed gen_regex
Former-commit-id: 5510fce675
2015-07-07 15:22:04 -04:00
Joshua Chin
53323f8ea7 added arabic tests
Former-commit-id: f83d31a357
2015-07-07 15:10:59 -04:00
Joshua Chin
d88470df4e changed default to minimum for word_frequency
Former-commit-id: 9aa773aa2b
2015-07-07 15:03:26 -04:00
Joshua Chin
16494f1869 added docstring to top_n_list
Former-commit-id: 0b25caaf24
2015-07-07 15:01:39 -04:00
Joshua Chin
f1e71839ea fix grammar
Former-commit-id: bd172594d3
2015-07-07 14:59:28 -04:00
Joshua Chin
589bb624af updated _emoji_char_class docstring
Former-commit-id: 10b5727725
2015-07-07 14:58:50 -04:00
Joshua Chin
d3a6b5413e removed intermediate lists
Former-commit-id: 5342ea3033
2015-07-07 14:57:45 -04:00
Joshua Chin
7b16164408 updated number of words to 5
Former-commit-id: 4b49b1a547
2015-07-07 14:56:40 -04:00
Joshua Chin
1f7c53b3dd updated word_frequency docstring
Former-commit-id: 4304a400f7
2015-07-07 14:56:12 -04:00
Joshua Chin
cec9e23aea run cB_to_freq only once per bucket
Former-commit-id: 5e8ef19321
2015-07-07 14:55:13 -04:00
Joshua Chin
512ab79302 use itertools.chain
Former-commit-id: 6a40e63060
2015-07-07 14:54:19 -04:00
Joshua Chin
e03de80278 fixed Error string
Former-commit-id: bbdc064528
2015-07-07 14:51:46 -04:00
Joshua Chin
b81c04a182 updated gen_regex to be run as script
Former-commit-id: 22fbea4248
2015-07-07 14:50:56 -04:00
Joshua Chin
22889de63c removed unused imports
Former-commit-id: f3f9a654ea
2015-07-07 14:48:11 -04:00
Joshua Chin
20c4930435 updated imports
Former-commit-id: f2b615b0f0
2015-07-07 14:46:42 -04:00
Joshua Chin
693849b02d imports are already cached
Former-commit-id: b1cd2e01d3
2015-07-07 14:44:50 -04:00
Joshua Chin
6deced5244 factored out regex generation
Former-commit-id: 476a909e4d
2015-07-07 14:38:21 -04:00